Re: [Xen-devel] [PATCH RFC 3/9] xen: arm: handle concatenated root tables in dump_pt_walk

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-30 at 17:58 +0100, Julien Grall wrote:
> > -    first = __map_domain_page(p2m->root);
> > -    dump_pt_walk(first, addr, P2M_ROOT_LEVEL);
> > -    unmap_domain_page(first);
> > +    dump_pt_walk(page_to_maddr(p2m->root), addr,
> 
> You can directly use p2m->vttbr and avoid to call page_to_maddr.

Not quite since vttbr contains the vmid encoding.

page_to_maddr is cheap enough for a debug path I think.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel