Re: [Xen-devel] [PATCH] numa.c: convert to xen coding style

[Elena Ufimtseva <ufimtseva@xxxxxxxxx>]

On Thu, Sep 4, 2014 at 6:43 AM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
> On gio, 2014-09-04 at 00:04 -0400, Elena Ufimtseva wrote:
>> Convert to Xen coding style from mixed one.
>>
> Ah... Much better, thanks Elena for doing this! :-)
>
> I only have one nit.
>
>> --- a/xen/arch/x86/numa.c
>> +++ b/xen/arch/x86/numa.c
>
>>  void __init numa_init_array(void)
>>  {
>> -     int rr, i;
>> -     /* There are unfortunately some poorly designed mainboards around
>> -        that only connect memory to a single CPU. This breaks the 1:1 
>> cpu->node
>> -        mapping. To avoid this fill in the mapping for all possible
>> -        CPUs, as the number of CPUs is not known yet.
>> -        We round robin the existing nodes. */
>> -     rr = first_node(node_online_map);
>> -     for (i = 0; i < nr_cpu_ids; i++) {
>> -             if (cpu_to_node[i] != NUMA_NO_NODE)
>> -                     continue;
>> -             numa_set_node(i, rr);
>> -             rr = next_node(rr, node_online_map);
>> -             if (rr == MAX_NUMNODES)
>> -                     rr = first_node(node_online_map);
>> -     }
>> -
>> +    int rr, i;
>> +    /* There are unfortunately some poorly designed mainboards around
>> +       that only connect memory to a single CPU. This breaks the 1:1 
>> cpu->node
>> +       mapping. To avoid this fill in the mapping for all possible
>> +       CPUs, as the number of CPUs is not known yet.
>> +       We round robin the existing nodes. */
>>
> We are not super consistent when it comes to code comments, but I think
> this should have become something like this:
>
> /*
>  * Example, multi-line comment block.
>  *
>  * Note beginning and end markers on separate lines and leading '*'.
>  */
>
> With this fixed,
>
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
>
> Regards,
> Dario
>
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
>

Thanks Jan, Dario.

Sorry for missing 'i'.

Jan, do you want me to re-send with what Dario mentioned?

Elena


-- 
Elena

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel