Re: [Xen-devel] [PATCH v3 15/15] tools/tests: Enable xen-access on ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hello Tamas,

On 02/09/14 05:15, Tamas K Lengyel wrote:
> On Mon, Sep 1, 2014 at 11:26 PM, Julien Grall <julien.grall@xxxxxxxxxx
> <mailto:julien.grall@xxxxxxxxxx>> wrote:
>     On 01/09/14 10:22, Tamas K Lengyel wrote:
>
>         diff --git a/tools/tests/xen-access/__Makefile
>         b/tools/tests/xen-access/__Makefile
>         index 65eef99..698355c 100644
>         --- a/tools/tests/xen-access/__Makefile
>         +++ b/tools/tests/xen-access/__Makefile
>         @@ -7,9 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
>            CFLAGS += $(CFLAGS_libxenguest)
>            CFLAGS += $(CFLAGS_xeninclude)
>
>         -TARGETS-y :=
>         -TARGETS-$(CONFIG_X86) += xen-access
>         -TARGETS := $(TARGETS-y)
>         +TARGETS := xen-access
>
>
>     I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk
>     to config/*.mk and use the defition here to build or not xen-access.
>
>
> I'm not a fan of that approach. How about this:
What is the problem with this solution? xen-access should be compiled 
when Xen has HAS_MEM_ACCESS=y.
As you enabled HAS_MEM_ACCESS by default when the architecture is 
supported, using TARGETS-$(HAS_MEM_ACCESS) += xen-access will make the 
support for a new architecture easier.
Anyway, I will let the maintainers decide what is the best solution.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel