Re: [Xen-devel] [PATCH v2 17/18] xl: use libxl_retrieve_domain_configuration and JSON format

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-30 at 19:23 +0100, Wei Liu wrote:
> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> index 30bd4bf..23add95 100644
> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
> @@ -187,6 +187,10 @@ immediate effect but will be applied when the guest is 
> next
>  restarted. This command is useful to ensure that runtime modifications
>  made to the guest will be preserved when the guest is restarted.
>  
> +Libxl now has improved capabilities to handle dynamic domain configuration

How about "Since Xen 4.5 xl has improved ..."?

> +    config_c = libxl_domain_config_to_json(ctx, &d_config);
> +    if (!config_c) {
> +        fprintf(stderr, "unable to parse overridden config file\n");

I don't think this message matches the failure, does it? It's a failure
to convert the config to JSON I think?

> @@ -4348,6 +4375,9 @@ int main_config_update(int argc, char **argv)
>          exit(1);
>      }
>  
> +    fprintf(stderr, "WARN: libxl now has better capability to manage domain 
> configuration, "
> +            "avoid using this command when possible\n");

I think you can say "xl" in this context, the user of xl doesn't care
that it happens to be due to better scaffolding in the library.

> +
>      domid = find_domain(argv[1]);
>      argc--; argv++;
>  
> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> index 4279b9f..9bc0bca 100644
> --- a/tools/libxl/xl_cmdtable.c
> +++ b/tools/libxl/xl_cmdtable.c
> @@ -38,7 +38,9 @@ struct cmd_spec cmd_table[] = {
>      { "config-update",
>        &main_config_update, 1, 1,
>        "Update a running domain's saved configuration, used when rebuilding "
> -      "the domain after reboot",
> +      "the domain after reboot."
> +      "WARN: libxl now has better capability to manage domain configuration, 
> "
> +      "avoid using this command when possible",

Same.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel