Re: [Xen-devel] [PATCH v2 07/18] libxl: separate device add/rm complete callbacks

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-09-03 at 12:53 +0100, Ian Campbell wrote:
> On Thu, 2014-08-28 at 11:34 +0100, Wei Liu wrote:
> > > > +        libxl__ao_complete(egc, ao, aodev->rc);                        
> > > >  \
> > > > +    }
> > > > +
> > > > +/*
> > > > + * device_vtpm_rm_aocomplete
> > > > + * device_nic_rm_aocomplete
> > > > + * device_disk_rm_aocomplete
> > > > + * device_vfb_rm_aocomplete
> > > > + * device_vkb_rm_aocomplete
> > > > + */
> > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vtpm);
> > > > +DEFINE_DEVICE_RM_AOCOMPLETE(nic);
> > > > +DEFINE_DEVICE_RM_AOCOMPLETE(disk);
> > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vfb);
> > > > +DEFINE_DEVICE_RM_AOCOMPLETE(vkb);
> > > 
> > > I was going to suggest merging this with DEFINE_DEVICE_REMOVE but that
> > > is used twice for each device so that won't work. But perhaps consider
> > > adding  these in the same blocks as the usage of DEFINE_DEVICE_REMOVE?
> > > 
> > 
> > They're already placed right before DEFINE_DEVICE_RM macro. You
> > requested this in your last review so I've done it already. ;-)
> 
> Heh, what I meant there was to end up with:
> 
> /* disk */
> DEFINE_DEVICE_RM_AOCOMPLETE(disk);
> DEFINE_DEVICE_REMOVE(disk, remove, 0)
> DEFINE_DEVICE_REMOVE(disk, destroy, 1)
> 
> /* nic */

... oops, that button was "Send" not "Paste". Anyway I think I got the
important bits in ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel