Re: [Xen-devel] [PATCH] numa.c: use spaces instead of tabs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.09.14 at 11:52, <dario.faggioli@xxxxxxxxxx> wrote:
> On mer, 2014-09-03 at 00:18 -0400, Elena Ufimtseva wrote:
>> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>
>> ---
>>
> I think the patch does what the subject says, i.e., converting tabs to
> spaces, and does it right (I've only one question, see below).
> 
> However, does it make sense, while at it, to turn the file into a Xen's
> code stile compliant one? Because, if yes, there are other things than
> tabs-->spaces that needs fixing, I believe.

Yes, indeed - we don't use a style like what results from this patch.

>> @@ -121,83 +121,83 @@ static int __init 
> allocate_cachealigned_memnodemap(void)
>>   * maximum possible shift.
>>   */
>>  static int __init extract_lsb_from_nodes(const struct node *nodes,
>> -                                     int numnodes)
>> +                     int numnodes)
>>
> Perhaps I am the one missing something here, but shouldn't this still be
> aligned to the '(' above (through spaces, of course)?

Indeed it should.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel