Re: [Xen-devel] [PATCH v03 08/10] arm: add trap for remoteproc mmio accesses

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.09.14 at 17:46, <andrii.tseglytskyi@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -35,6 +35,7 @@
>  #include <asm/debugger.h>
>  #include <asm/p2m.h>
>  #include <asm/processor.h>
> +#include <asm/remoteproc_iommu.h>

And this doesn't break the build on x86? I think the entire change
ought to go into arch_domain_create().

> @@ -376,6 +377,12 @@ struct domain *domain_create(
>          spin_unlock(&domlist_update_lock);
>      }
>  
> +#ifdef HAS_REMOTEPROC
> +    if ( remoteproc_iommu_register_mmio_handlers(d) )
> +        printk("Failed to register remoteprocessor mmu mmio handlers for 
> domain %d\n",
> +               d->domain_id);
> +#endif

Such guest related printk()-s ought to be log-leveled. Plus with
an isolated change like this it remains entirely unclear whether
just logging a message here is the right kind of error handling.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel