Re: [Xen-devel] [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.09.14 at 13:10, <tiejun.chen@xxxxxxxxx> wrote:
> On 2014/9/2 18:15, Jan Beulich wrote:
>>>>> On 02.09.14 at 11:59, <tiejun.chen@xxxxxxxxx> wrote:
>>> +    case XENMEM_reserved_device_memory_map:
>>> +    {
>>> +        struct xen_mem_reserved_device_memory *xmrdm = NULL;
>>> +        struct xen_mem_reserved_device_memory_map xmrdmm;
>>> +        XEN_GUEST_HANDLE(xen_mem_reserved_device_memory_t) buffer;
>>> +        XEN_GUEST_HANDLE_PARAM(xen_mem_reserved_device_memory_t) 
>>> buffer_param;
>>> +        const struct iommu_ops *ops = iommu_get_ops();
>>> +        unsigned int nr_entries = 0;
>>> +        unsigned int i = 0;
>>> +
>>> +        xmrdm = ops->get_device_reserved_memory(&nr_entries);
> 
> Do we still need this iommu_ops somewhere else?

Not this one, but another one (as I had described further down).

>>> +        if ( !nr_entries )
> 
> Do we still need this 'nr_entries' here?

Doesn't look like so. But it's you coding this up - you ought to clearly
see what is needed and what not.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel