Re: [Xen-devel] [v5][PATCH 06/10] hvm_info_table: introduce nr_reserved_device_memory_map

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.08.14 at 13:02, <tiejun.chen@xxxxxxxxx> wrote:
> libxc can expose how many reserved device memory entries
> hvmloader should get. And '0' means that doesn't exist so
> we can skip this check.

I assume you introduce this without consumer to limit patch size. In
such a case title _and_ description should be more meaningful as
to what this really does and what it's intended use is.

> @@ -370,6 +375,9 @@ static int setup_guest(xc_interface *xch,
>      rc = check_rmrr_overlap(xch, mmio_start, mmio_start);

I skipped several tools side patches, but here I see that somewhere
you still left the term "RMRR" in the code, when you were asked
before to use more abstract naming (and this of course not only
extended to the public interface).

>      if ( rc < 0 )
>          goto error_out;
> +    /* Always return entries number. */
> +    else

The "else" here is bogus considering the "goto" above.

> --- a/xen/include/public/hvm/hvm_info_table.h
> +++ b/xen/include/public/hvm/hvm_info_table.h
> @@ -67,6 +67,9 @@ struct hvm_info_table {
>  
>      /* Bitmap of which CPUs are online at boot time. */
>      uint8_t     vcpu_online[(HVM_MAX_VCPUS + 7)/8];
> +
> +    /* How many reserved device memory does this domain have? */
> +    uint32_t    nr_reserved_device_memory_map;
>  };

This being defacto a private interface between tools and hvmloader
I wonder if it wouldn't be better to put this before the (in the future)
eventually growing vcpu_online[].

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel