Re: [Xen-devel] [PATCH v2 0/3] Xen VMware tools support

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 09/01/14 12:10, Jan Beulich wrote:
> > > > On 01.09.14 at 17:33, <dslutz@xxxxxxxxxxx> wrote:
> > changes RFC to v2:
> >
> > Jan Beulich:
> >    Add xen/arch/x86/hvm/vmware.c for cpuid_vmware_leaves
> >    Fewer patches
> > [...]
> >   xen/arch/x86/hvm/vmport/Makefile             |    1 +
> >   xen/arch/x86/hvm/vmport/backdoor_def.h       |  167 +++
> >   xen/arch/x86/hvm/vmport/guest_msg_def.h      |   87 ++
> >   xen/arch/x86/hvm/vmport/includeCheck.h       |   17 +
> >   xen/arch/x86/hvm/vmport/vmport.c             | 1436 ++++++++++++++++++++++++++
> >   xen/arch/x86/hvm/vmware.c                    |   85 ++
> I don't think you should be adding a new fine in hvm/ _and_ a
> new subdirectory. If VMware support requires more than one
> file, everything should probably go into hvm/vmware/.
Sure.
   -Don Slutz


> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel