[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5] xen: arm: introduce uImage probe function for Dom0

Hi Oleksandr,

On 28/08/14 06:54, Oleksandr Dmytryshyn wrote:
  #ifdef CONFIG_ARM_64
   * Check if the image is a 64-bit Image.
@@ -398,6 +467,8 @@ int kernel_probe(struct kernel_info *info)
      rc = kernel_zimage64_probe(info, start, size);
      if (rc < 0)
+        rc = kernel_uimage_probe(info, start, size);
+    if(rc < 0 )

NIT: the coding style is:

if ( rc < 0 )

It looks like the other if in this function don't respect the coding style. I wouldn't resend a new version of this patch this small NIT. Maybe Ian can fix it when it will be applied?


Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.