Re: [Xen-devel] [PATCH RFC V9 4/5] xen, libxc: Request page fault injection via libxc

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.08.14 at 13:48, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> +    case XEN_DOMCTL_request_pagefault:
> +    {
> +        unsigned int vcpu = op->u.vcpucontext.vcpu;

So you're using two different structures of the union - how can
that possibly work? You've got a 32-bi padding field, which you can
easily use to indicate the desired vCPU. Apart from that I'm not
seeing how your intended "any vCPU" is now getting handled.

Jan

> +        struct vcpu *v;
> +
> +        ret = -EINVAL;
> +        if ( vcpu >= d->max_vcpus || (v = d->vcpu[vcpu]) == NULL ||
> +             !is_hvm_domain(d) )
> +            break;
> +
> +        v->arch.pagefault_request.address_space =
> +            op->u.request_pagefault_info.address_space;
> +        v->arch.pagefault_request.virtual_address =
> +            op->u.request_pagefault_info.virtual_address;
> +        v->arch.pagefault_request.errcode =
> +            op->u.request_pagefault_info.errcode;
> +        v->arch.pagefault_request.valid = 1;
> +
> +        ret = 0;
> +    }
> +    break;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel