Re: [Xen-devel] [PATCH v8 3/9] vnuma hook to debug-keys u

[Elena Ufimtseva <ufimtseva@xxxxxxxxx>]

On Wed, Aug 27, 2014 at 4:26 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Aug 26, 2014 at 03:45:00AM -0400, Elena Ufimtseva wrote:
>> Add debug-keys hook to display vnuma topology.
>>
>> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>
>
> Now that I had led you astray on the style (truly sorry
> and I am really happy Jan spotted it), when that gets fixed
> to be right type you can add 'Reviewed-by: Konrad Rzeszutek
> Wilk <konrad.wilk@xxxxxxxxxx>'.
>
> Or if there is not enough time, there could be a cleanup
> patch to fix those style guide later on.
>
>> ---
>>  xen/arch/x86/numa.c |   35 ++++++++++++++++++++++++++++++++++-
>>  1 file changed, 34 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c
>> index b141877..9efceac 100644
>> --- a/xen/arch/x86/numa.c
>> +++ b/xen/arch/x86/numa.c
>> @@ -347,7 +347,7 @@ EXPORT_SYMBOL(node_data);
>>  static void dump_numa(unsigned char key)
>>  {
>>       s_time_t now = NOW();
>> -     int i;
>> +     int i, j, n, err;
>>       struct domain *d;
>>       struct page_info *page;
>>       unsigned int page_num_node[MAX_NUMNODES];
>> @@ -389,6 +389,39 @@ static void dump_numa(unsigned char key)
>>
>>               for_each_online_node(i)
>>                       printk("    Node %u: %u\n", i, page_num_node[i]);
>> +
>> +             if ( d->vnuma )
>> +             {
>> +                     printk("    Domain has %u vnodes, %u vcpus\n",
>> +                                d->vnuma->nr_vnodes, d->max_vcpus);
>> +                     for ( i = 0; i < d->vnuma->nr_vnodes; i++ )
>> +                     {
>> +                             err = snprintf(keyhandler_scratch, 12, "%u",
>> +                                                    
>> d->vnuma->vnode_to_pnode[i]);
>> +                             if ( err < 0 || d->vnuma->vnode_to_pnode[i] == 
>> NUMA_NO_NODE )
>> +                                     snprintf(keyhandler_scratch, 3, "???");
>> +                             printk("        vnode %3u - pnode %s,", i, 
>> keyhandler_scratch);
>> +
>> +                             printk(" %"PRIu64" MB, ",
>> +                                        (d->vnuma->vmemrange[i].end - 
>> d->vnuma->vmemrange[i].start) >> 20);
>> +
>> +                             printk("vcpu nrs: ");
>> +                             for ( j = 0, n = 0; j < d->max_vcpus; j++ )
>> +                             {
>> +                                     if ( d->vnuma->vcpu_to_vnode[j] == i )
>> +                                     {
>> +                                             if ( ((n + 1) % 8) == 0 )
>> +                                                     printk("%d\n", j);
>> +                                             else if ( !(n % 8) && n != 0 )
>> +                                                     printk("%s%d ", "      
>>        ", j);
>> +                                             else
>> +                                                     printk("%d ", j);
>> +                                             n++;
>> +                                     }
>> +                             }
>> +                             printk("\n");
>> +                     }
>> +             }
>>       }
>>
>>       rcu_read_unlock(&domlist_read_lock);
>> --
>> 1.7.10.4
>>


Thanks Konrad!

Will be posting tonight next version.


-- 
Elena

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel