Re: [Xen-devel] [PATCH 08/13] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Aug 26, Ian Campbell wrote:

> On Mon, 2014-07-28 at 11:05 +0200, Olaf Hering wrote:
> > +++ b/tools/hotplug/Linux/Makefile
> > @@ -32,18 +32,47 @@ XEN_SCRIPT_DATA += block-common.sh
> >  UDEV_RULES_DIR = $(CONFIG_DIR)/udev
> >  UDEV_RULES = xen-backend.rules $(UDEV_RULES-y)
> >  
> > +USED_PATH = "_used_path.sh"
> > +genpath-target = $(call buildmakevars2file,$(USED_PATH))
> > +$(eval $(genpath-target))
> I can't see where _used_path.sh is consumed.

I will add a comment, has something todo with the need to rerun the
rules if the PATHS do change.

> > +%: %.in
> > +   set -e; \
> > +           rm -f $@.new ; \
> > +           sed 's|@@XEN_SCRIPT_DIR@@|$(XEN_SCRIPT_DIR)|g' $< >$@.new ; \
> > +           $(call move-if-changed,$@.new,$@)
> 
> Can you make these substitutions directly from tools/configure.ac? I
> think Luis did something similar for the systemd stuff?

Maybe, what I remmeber is that sed is used as well now.
I have to rebase my series to staging and see how the result looks like. 

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel