Re: [Xen-devel] [PATCH v1 3/4] libxl: add rt scheduler

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 25, 2014 at 11:55:26AM -0400, Meng Xu wrote:
[...]
> 
> âI see. Right now, it is disposed by the caller in xl.â
> 
> 
> > > +    if (vcpu_index < 0 || vcpu_index > num_vcpus)
> > > +    {
> >
> > Libxl coding style normally has { in the same line of "if" "for" etc.
> > Please
> > check and fix other occurences.
> >
> 
> âA quick question:
> Should I use the style "if () { " for all files in the tool stack or just
> in libxl files?
> 
> If I need to use this style in all tool stack files, I will check and
> modify them. (Right now, I just made the correction for this exact patch.)
> 

There is a CODING_STYLE file in top level directory for hypervisor.
Libxl also has one in its own directory.

If there's no coding guideline I think you need to follow existing code.
In your case libxc doesn't have one, you just follow what's already
there to be consistent.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel