Re: [Xen-devel] [PATCH V3] Update pvSCSI protocol description

[Juergen Gross <jgross@xxxxxxxx>]

On 08/25/2014 04:30 PM, Jan Beulich wrote:
> > > > On 25.08.14 at 16:23, <"jgross@xxxxxxxx".non-mime.internet> wrote:
> > +/*
> > + * The following interface is deprecated!
> > + */
> >   #define VSCSIIF_SG_LIST_SIZE ((sizeof(vscsiif_request_t) - 4) \
> >                                 / sizeof(vscsiif_segment_t))
> Right, but ...
>
> > @@ -89,10 +224,12 @@ struct vscsiif_sg_list {
> >       vscsiif_segment_t seg[VSCSIIF_SG_LIST_SIZE];
> >   };
> >   typedef struct vscsiif_sg_list vscsiif_sg_list_t;
> > +/* End of deprecated interface */
> >
> > +/* Size of one response is 252 bytes */
> >   struct vscsiif_response {
> > -    uint16_t rqid;
> > -    uint8_t act;               /* valid only when backend supports SG_PRESET */
> > +    uint16_t rqid;          /* identifies request */
> > +    uint8_t padding;
> ... here you still remove a piece of that.
Indeed.

I'll post V4 tomorrow...


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel