[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 1/4] x86/mm: Shadow and p2m changes for PV mem_access

>>> On 25.08.14 at 14:45, <glguida@xxxxxxxxx> wrote:
> On Fri, Aug 22, 2014 at 10:34 AM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> wrote:
>> I am concerned with the addition of a the vcpu specifics to
>> shadow_write_entries().  Most of the shadow code is already vcpu centric
>> where it should be domain centric, and steps are being made to alleviate
>> these problems.
> The historical reason the code is set up this way, if you are referring to
> the fact that every shadow operation is vcpu-specific while the interface
> to it is domain specific, is due to the design choice of leaving the door
> open to experiment with per-vcpu shadows.
> That always looked like a nice feature, I am not sure anybody ever
> implemented it. I would advocate -- for the sake of code consistency -- to
> keep the current shadow internal interfaces per-vcpu in upcoming patches,
> and change it when you propose your domain-centric patch, effectively
> killing this probably never-exploited opportunity.

Except that a number of places broke that possible route already,
by using vCPU 0 in several places where only a domain gets passed


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.