Re: [Xen-devel] [PATCH v5 1/3] x86/viridian: Re-purpose the HVM parameter to be a feature mask

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("[PATCH v5 1/3] x86/viridian: Re-purpose the HVM parameter 
to be a feature mask"):
> The viridian option in xl.cfg(5) has also been changed to a string list so
> that the sets can be individually sepcified. For compatibility, if the
> option is specified as a boolean, then a true (1) value will be translated
> to a string list containing "base" and "freq".

This is correct, I think.  But the libxl API should be in numbers, not
a string list.  Text to string conversion should be done in xl, not
libxl.

I think that these flag values ought to be represented in the IDL, so
that text-to-string conversion can be done automatically.

I looked at the existing IDL definitions and there don't seem to be
any flags of this kind.  So I think this will involve a inventing new
kind of IDL type.  It might be possible to adapt Enumeration.  It
might be enough simply to provide a way to make an Enumeration whose
corresponding typedef is to a uint32_t.

Does this make any kind of sense ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel