Re: [Xen-devel] [PATCH] evtchn: clean last_vcpu_id on EVTCHNOP_reset to avoid crash

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.08.14 at 16:22, <vkuznets@xxxxxxxxxx> wrote:
> --- a/xen/common/event_fifo.c
> +++ b/xen/common/event_fifo.c
> @@ -61,6 +61,15 @@ static struct evtchn_fifo_queue *lock_old_queue(const 
> struct domain *d,
>      for ( try = 0; try < 3; try++ )
>      {
>          v = d->vcpu[evtchn->last_vcpu_id];
> +
> +        if ( !v->evtchn_fifo )
> +        {
> +            gdprintk(XENLOG_ERR,
> +                     "domain %d vcpu %d has no control block!\n",
> +                     d->domain_id, v->vcpu_id);

But not gdprintk() please (which also prints the current vCPU/domain
(confusing everyone looking at such a message), and make use of
%pv.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel