Re: [Xen-devel] [PATCH v3 2/3] xen/arm: reimplement xen_dma_unmap_page & friends

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 1 Aug 2014, Stefano Stabellini wrote:
> +static void __xen_dma_page_dev_to_cpu(struct device *hwdev, dma_addr_t 
> handle,
> +             size_t size, enum dma_data_direction dir)
> +{
> +     /* Cannot use __dma_page_dev_to_cpu because we don't have a
> +      * struct page for handle */
> +
> +     if (dir == DMA_TO_DEVICE)

This should be:
    if (dir != DMA_TO_DEVICE)

Thomas, could you please confirm that with this small fix
http://pastebin.com/FPRf7pgL goes away?


> +             outer_inv_range(handle, handle + size);
> +
> +     dma_cache_maint(handle & PAGE_MASK, handle & ~PAGE_MASK, size, dir, 
> dmac_unmap_area);
> +}

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel