[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 09/21] xen/arm: Release IRQ routed to a domain when it's destroying

On Thu, 7 Aug 2014, Julien Grall wrote:
> On 08/07/2014 04:36 PM, Stefano Stabellini wrote:
> >> But I doubt we will have PPIs in future, there is more issues to handle
> >> (such as the number of VCPUs doesn't match the number of physical CPUs).
> > 
> > In that case, why not call the two functions release_guest_spi and
> > gic_remove_spi_from_guest?
> Because the 2 functions to route the irq are called route_irq_to_guest
> and gic_route_irq_to_guest.

I would prefer to avoid introducing more functions that look like they
can handle any irqs but actually they cannot by design.
I would be OK with the asymmetry in function names. We could also turn
route_irq_to_guest into route_spi_to_guest and gic_route_irq_to_guest
into gic_route_spi_to_guest.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.