[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3] tools/tests: Add EIP check to test_x86_emulator.c

>>> On 07.08.14 at 13:38, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> The test now also checks that EIP was modified after emulating
> instructions after (and including) the "movq %mm3,(%ecx)..."
> code block. This patch depends on Jan Beulich's "x86_emulate:
> properly do IP updates and other side effects on success" patch
> for the tests to succeed.
> Changes since V1:
>  - Now checking if the value in EIP is correct instead of simply
>    checking that EIP has been modified.
> Changes since V1:
>  - Added brackets for (unsigned long)(&instr[0] + instr_size).

Quite pointlessly, but it's fine either way. And I guess I'll do some
further work on it anyway before committing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.