[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/tests: Add EIP check to test_x86_emulator.c

>>> On 07.08.14 at 10:35, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/07/2014 11:32 AM, Jan Beulich wrote:
>>>>> On 07.08.14 at 10:18, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> On 07/08/2014 09:16, Razvan Cojocaru wrote:
>>>> The test now also checks that EIP was modified after emulating
>>>> instructions after (and including) the "movq %mm3,(%ecx)..."
>>>> code block.
>>>> Signed-off-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
>>> These checks do check that the instruction pointer has changed, which
>>> catches your problem, but doesn't check that it has changed correctly. 
>>> You need to work out exactly how long the instruction is a verify that
>>> eip points to first byte of the next instruction.
>> And apart from that this should be done for all tests, not just the
>> MMX/SSE/AVX ones.
> The other tests already do this, but there it's simpler to check.

Ah, my bad then (both in not having checked the code before
replying, and in not having added these checks back when I
added those tests) - I'm sorry.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.