[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC V4 4/5] xen, libxc: Request page fault injection via libxc


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Mon, 04 Aug 2014 18:23:07 +0300
  • Cc: kevin.tian@xxxxxxxxx, ian.campbell@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, eddie.dong@xxxxxxxxx, xen-devel@xxxxxxxxxxxxx, jun.nakajima@xxxxxxxxx, ian.jackson@xxxxxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Mon, 04 Aug 2014 15:23:19 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=dCtW29SR3KGCozF0/HTmlDePSsHo+UioE6hPLPjDAzo7XMx2t2h2GFS7sFd5BcFbBLIwu+zkZZuTiuA7Y63mFVqNMMD4pTK/Q5GK3SOLBfzZA3lR/6C7eNfq/fAOhAZV2dXKrSPTD7vxgadcYf6Hf5HiznyPYt4WDTuVo+efEx6UMhvLz5itnID4ImJyRVlas54iNOcd3o4NNlB480khoS9B37r26k2sifRrG/fRx2/ZjRYmO59oN0AAUsQ9ShtHbhtzO4TnScYyXHuoo7dcKqTulqEB5RsKmOJp4clwECvCbU0NfAk7PwbyVOxeLtT+6eRJ05Ut6dwFsgGxpJShzQ==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/04/2014 06:22 PM, Razvan Cojocaru wrote:
> On 08/04/2014 06:21 PM, Jan Beulich wrote:
>>>>> On 04.08.14 at 17:11, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> On 08/04/2014 05:26 PM, Jan Beulich wrote:
>>>>>>> On 04.08.14 at 13:30, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>>>> +static bool_t vmx_check_pf_injection(void)
>>>>> +{
>>>>> +    struct vcpu *curr = current;
>>>>> +    struct domain *d = curr->domain;
>>>>> +    struct segment_register seg;
>>>>> +    unsigned long ev;
>>>>> +    uint32_t pending_event = 0;
>>>>> +
>>>>> +    if ( likely(d->arch.hvm_domain.fault_info.virtual_address == 0 )
>>>>
>>>> Bad space before ). And my question stands: Why is VA zero
>>>> special?
>>>
>>> It's special because for our purposes (mostly Windows HVM guests, but I
>>> think the same applies to Linux), that page is reserved and it's never
>>> swapped out, so there would be no point in asking for a page fault
>>> injection there.
>>>
>>> If you think that a code comment is not enough here and that in the
>>> future somebody might legitimately want to use 0 as a proper value, I'll
>>> add a "valid" member and use that explicitly.
>>
>> Perhaps in another thread I said this earlier today already: In the
>> HVM code we should not be making assumptions about particular
>> guest behavior, except when it comes to optimization for certain
>> special cases.
> 

OK, I'll address that as well.


Thanks,
Razvan Cojocaru

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.