Re: [Xen-devel] [PATCH v2] xen: fix cpuid reporting on PVH Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.14 at 12:32, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/08/14 16:26, Roger Pau Monne wrote:
>> --- a/xen/arch/x86/traps.c
>> +++ b/xen/arch/x86/traps.c
>> @@ -803,12 +803,16 @@ void pv_cpuid(struct cpu_user_regs *regs)
>>      if ( (regs->eax & 0x7fffffff) == 0x00000001 )
>>      {
>>          /* Modify Feature Information. */
>> -        __clear_bit(X86_FEATURE_VME, &d);
>>          if ( !cpu_has_apic )
>>              __clear_bit(X86_FEATURE_APIC, &d);
>> -        __clear_bit(X86_FEATURE_PSE, &d);
>> -        __clear_bit(X86_FEATURE_PGE, &d);
>> -        __clear_bit(X86_FEATURE_PSE36, &d);
> 
> Newline here...
> 
>> +        if ( !is_pvh_vcpu(curr) )
>> +        {
>> +            __clear_bit(X86_FEATURE_PSE, &d);
>> +            __clear_bit(X86_FEATURE_PGE, &d);
>> +            __clear_bit(X86_FEATURE_PSE36, &d);
>> +            __clear_bit(X86_FEATURE_VME, &d);
> 
> Why do PVH guests care about VME?  They can't use it as far as I am aware.

I don't think it particularly cares, but it also seems unnecessary and
inconsistent to hide a feature from it without need.

>> +        }
>> +
> 
> ... and not here.

I've already taken care of these formatting issues in the to-be-
committed version.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel