Re: [Xen-devel] [PATCH 3/3] x86/HVM: command line option adjustments

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.07.14 at 18:55, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 07/30/2014 12:09 PM, Jan Beulich wrote:
>>   
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -70,8 +70,10 @@
>>   
>>   bool_t __read_mostly hvm_enabled;
>>   
>> +#ifdef DBG_LEVEL_0
>>   unsigned int opt_hvm_debug_level __read_mostly;
>>   integer_param("hvm_debug", opt_hvm_debug_level);
>> +#endif
> 
> 
> Do you think "#ifndef NDEBUG" might be better given that it is what 
> defines DBG_LEVEL_0 (and all other DBG_LEVELs)?

No, specifically not: If someone wants to alter the behavior to e.g.
include the option (and the effect it takes) in a non-debug build, the
way it's done this requires code modification in _exactly one place_.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel