Re: [Xen-devel] [PATCH v4 0/2] x86/HVM: Properly handle SMAP check in certain cases

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Sander Eikelenboom [mailto:linux@xxxxxxxxxxxxxx]
> Sent: Wednesday, July 30, 2014 9:14 PM
> To: Jan Beulich
> Cc: Wu, Feng; xen-devel@xxxxxxxxxxxxx; keir@xxxxxxx; tim@xxxxxxx
> Subject: Re: [PATCH v4 0/2] x86/HVM: Properly handle SMAP check in certain
> cases
> 
> 
> Wednesday, July 30, 2014, 10:24:39 AM, you wrote:
> 
> >>>> On 30.07.14 at 03:35, <feng.wu@xxxxxxxxx> wrote:
> >> V4:
> >> - Adjust the branch handling in update_runstate_area().
> >> - Remove the pointless initial value of smap_check_policy_t.
> >> - Using __packed__ attribute for smap_check_policy_t to make
> >> its size down to one byte.
> >> - Adjust the position of 'smap_check_policy' in struct arch_vcpu
> >> to use the current padding in this structure.
> >> - Coding style.
> >>
> >> Feng Wu (2):
> >>   x86/hvm: Always do SMAP check when updating runstate_guest(v)
> >>   x86/hvm: Always do SMAP check when updating secondary system time
> for
> >>     guest
> >>
> >>  xen/arch/x86/domain.c        | 27 +++++++++++++++++++++++----
> >>  xen/arch/x86/mm/guest_walk.c | 39
> ++++++++++++++++++++++++++-------------
> >>  xen/arch/x86/time.c          | 10 +++++++++-
> >>  xen/include/asm-x86/domain.h | 19 +++++++++++++++++--
> >>  4 files changed, 75 insertions(+), 20 deletions(-)
> 
> > Sander,
> 
> > can you confirm this addresses the issue you had?
> 
> > Jan
> 
> Hi Jan / Feng,
> 
> It wasn't so much of an issue in the sense that i only got this warning 
> (didn't
> notice any other adverse effects my self):
> 
> (XEN) [2014-07-30 11:41:02] Segment register inaccessible for d1v0
> (XEN) [2014-07-30 11:41:02] (If you see this outside of debugging activity, 
> please
> report to xen-devel@xxxxxxxxxxxxxxxxxxxx)

Printing out this message means there are some issues, since the function 
returns
from that point directly without executing the remaining stuff, which is 
incorrect.
> 
> But i just tested the v4 patches and the warning is gone !

Thanks a lot for the testing!

Thanks,
Feng

> 
> Thanks,
> 
> Sander


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel