[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Two Coverty issues found in 0aacc28bd73ba "x86, amd_ucode: support multiple container files appended together"


The most recent Coverity run has found two issues in cpu_request_microcode()

The first is dead code (CID 1229147).  The entire clause starting at 409
is dead, as there is indeed no possible way to leave the previous while
loop with error set.

The more concerning is a resource leak (CID 1229148) of mc_amd given
certain "goto out" bits of error handling.  One flagged codepath is via
the "goto out" on line 405.

Would you mind taking a look at fixing the error handling?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.