[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8 00/19] x86/PMU: Xen PMU PV(H) support



On 07/29/2014 04:07 AM, Jan Beulich wrote:
On 01.07.14 at 16:37, <boris.ostrovsky@xxxxxxxxxx> wrote:
Changes in v8:

* Cleaned up a bit definitions of struct xenpf_symdata and xen_pmu_params
* Added compat checks for vpmu structures
* Converted vpmu flag manipulation macros to inline routines
* Reimplemented vpmu_unload_all() to avoid long loops
* Reworked PMU fault generation and handling (new patch #12)
* Added checks for domain->vcpu[] non-NULLness
* Added more comments, renamed some routines and macros, code style cleanup
Having gone through this series once more (with often just minor
comments), I'd say the series could go in once those comments
got addressed.

Great!

There will be one more bug fix in the next revision. I need to swap the order of 'context_saved(prev)' and 'vpmu_load(next)' in context_switch() because I need prev->is_running to be clear.

But since I didn't follow the discussion of the Linux
side patches, interface-wise it wouldn't make sense if there were
objections in that area there. Could you please summarize the
status of the review process there?

The kernel part is being reviewed and the comments so far (mostly from David) were not related to interfaces. I will post the new version soon.

The tool part (perf) has not been posted yet but it has no dependence on interfaces.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.