[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix qemu building with older make

Jan Beulich writes ("[PATCH] fix qemu building with older make"):
> The $(or ) builtin (uses introduced by commits ffbf089357 and
> 8962a8f951) is supported only from make 3.81 onwards, yet we claim to
> only require make 3.80. Introduce a good enough fallback.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> --- a/Config.mk
> +++ b/Config.mk
> @@ -12,6 +12,7 @@ space   := $(empty) $(empty)
>  # fallback for older make
>  realpath = $(wildcard $(foreach file,$(1),$(shell cd -P $(dir $(file)) && 
> echo "$$PWD/$(notdir $(file))")))
> +or       = $(if $(strip $(1)),$(1),$(if $(strip $(2)),$(2),$(if $(strip 
> $(3)),$(3),$(if $(strip $(4)),$(4)))))

Can we (a) have a comment here explaining why (b) have some kind of
time limit on how long we need to support make 3.80 ?

3.81 was released upstream over eight years ago in April 2006.

(AFAICT as far as Debian goes that means it has been in every Debian
release since etch, which was released in April 2007.)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.