Re: [Xen-devel] [PATCH 2/4 v3] KVM: use pci device flag operation helper functions

[Ethan Zhao <ethan.kernel@xxxxxxxxx>]

This patch was already
Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
I forgot to add the Ack tag.

Thanks,
Ethan

Sorry for last post in HTML format with ipad.

On Tue, Jul 29, 2014 at 12:06 PM, Ethan Zhao <ethan.zhao@xxxxxxxxxx> wrote:
> Use helper function instead of direct operation to pci device
> flag when set device to assigned or deassigned.
>
> Signed-off-by: Ethan Zhao <ethan.zhao@xxxxxxxxxx>
> ---
>  v3: amend helper functions naming.
>  virt/kvm/assigned-dev.c |    2 +-
>  virt/kvm/iommu.c        |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
> index bf06577..d122bda 100644
> --- a/virt/kvm/assigned-dev.c
> +++ b/virt/kvm/assigned-dev.c
> @@ -302,7 +302,7 @@ static void kvm_free_assigned_device(struct kvm *kvm,
>         else
>                 pci_restore_state(assigned_dev->dev);
>
> -       assigned_dev->dev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
> +       pci_clear_dev_assigned(assigned_dev->dev);
>
>         pci_release_regions(assigned_dev->dev);
>         pci_disable_device(assigned_dev->dev);
> diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c
> index 0df7d4b..8cfe021 100644
> --- a/virt/kvm/iommu.c
> +++ b/virt/kvm/iommu.c
> @@ -194,7 +194,7 @@ int kvm_assign_device(struct kvm *kvm,
>                         goto out_unmap;
>         }
>
> -       pdev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED;
> +       pci_set_dev_assigned(pdev);
>
>         dev_info(&pdev->dev, "kvm assign device\n");
>
> @@ -220,7 +220,7 @@ int kvm_deassign_device(struct kvm *kvm,
>
>         iommu_detach_device(domain, &pdev->dev);
>
> -       pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED;
> +       pci_clear_dev_assigned(pdev);
>
>         dev_info(&pdev->dev, "kvm deassign device\n");
>
> --
> 1.7.1
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel