[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v9 10/10] xen/arm: make accesses to desc->status flags atomic
On Mon, 28 Jul 2014, Julien Grall wrote: > Hi Stefano, > > On 07/24/2014 06:33 PM, Stefano Stabellini wrote: > > @@ -305,13 +306,13 @@ static int __setup_irq(struct irq_desc *desc, > > unsigned int irqflags, > > * - if the IRQ is marked as shared > > * - dev_id is not NULL when IRQF_SHARED is set > > */ > > - if ( desc->action != NULL && (!(desc->status & IRQF_SHARED) || > > !shared) ) > > + if ( desc->action != NULL && (!test_bit(_IRQF_SHARED, &desc->status) > > || !shared) ) > > return -EINVAL; > > if ( shared && new->dev_id == NULL ) > > return -EINVAL; > > > > if ( shared ) > > - desc->status |= IRQF_SHARED; > > + set_bit(IRQF_SHARED, &desc->status); > > Shouldn't it be _IRQF_SHARED? well spotted! thanks! _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |