[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] cmdline_parse: Also pass bool_assert to OPT_CUSTOM so that parse_bool can be used correctly.

Don Slutz wrote:
This adding of a new parameter to all custom parameter parsers,
with rarely any actually using it is a no-go as far as I'm concerned.
That said, being of boolean type, this would need to be bool_t

I considered adding a new custom type, but when this way.  I would think
that if a custom parameter parser is ignoring the "no-" (which they all do)
they should be reporting on it.

I.E. "no-lapic" currently means "lapic" and "no-nolapic" means "nolapic"
with out any message to that effect.

The better fix here would be to reject options such as "no-lapic" as invalid. This could be done within cmdline_parse() by rejecting matches on anything other than OPT_{BOOL,INVBOOL} options if optkey has a "no-" prefix.

Adding a bool parameter to every custom parameter parser is not really going to fly.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.