[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v9 02/10] xen/arm: move setting GIC_IRQ_GUEST_QUEUED earlier
Hi Stefano, On 07/24/2014 06:33 PM, Stefano Stabellini wrote: > It makes the code cleaner, especially with the following patches. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > Acked-by: Julien Grall <julien.grall@xxxxxxxxxx> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > --- > xen/arch/arm/vgic.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c > index ebfec83..8255e96 100644 > --- a/xen/arch/arm/vgic.c > +++ b/xen/arch/arm/vgic.c > @@ -321,13 +321,6 @@ void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int > irq) > > spin_lock_irqsave(&v->arch.vgic.lock, flags); > > - if ( !list_empty(&n->inflight) ) > - { > - set_bit(GIC_IRQ_GUEST_QUEUED, &n->status); > - gic_raise_inflight_irq(v, irq); > - goto out; > - } > - > /* vcpu offline */ > if ( test_bit(_VPF_down, &v->pause_flags) ) > { > @@ -335,10 +328,17 @@ void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int > irq) > return; > } > > + set_bit(GIC_IRQ_GUEST_QUEUED, &n->status); > + > + if ( !list_empty(&n->inflight) ) > + { > + gic_raise_inflight_irq(v, irq); > + goto out; > + } > + NIT: The line above contains a space. It should be empty. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |