[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v4][PATCH 1/2] xen:x86:mm:p2m: introduce set_rmrr_p2m_entry

>>> On 28.07.14 at 13:42, <tiejun.chen@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -858,6 +858,32 @@ int set_mmio_p2m_entry(struct domain *d, unsigned long 
> gfn, mfn_t mfn)
>      return set_typed_p2m_entry(d, gfn, mfn, p2m_mmio_direct);
>  }
> +int set_rmrr_p2m_entry(struct domain *d, unsigned long gfn, mfn_t mfn)

Leaving aside all the previously raised points making me hesitate to
accept the pair of patches on their own, let's please try to avoid
having Intel specific function names in non-Intel-specific code unless
that's really the best choice. In the case here, you could
s/rmrr/identity/ and at once drop the redundant mfn argument (the
function can construct this for the call to p2m_set_entry(), and the
function name will make it obvious why this gets derived from gfn).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.