[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch v2 1/1] Add Odroid-XU (Exynos 5410)

On Mon, 2014-07-28 at 12:32 +0100, Julien Grall wrote:

> Less than 5% of the code is shared. It's perfectly fine to have 2
> different platforms

To be clear, I'm fine with *either* approach rather than having a strong
preference for one over the other where the differences are relatively
minor (as they are here IMHO).

> >>> @@ -122,7 +177,7 @@ PLATFORM_START(exynos5, "SAMSUNG EXYNOS5")
> >>>       .init_time = exynos5_init_time,
> >>>       .specific_mapping = exynos5_specific_mapping,
> >>
> >> I'm not sure if those specific mapping are relevant for the odroid XU... 
> >> Hence IIRC, they are now defined in the device tree.
> > 
> > A difference in this *would* require a separate platform, since this is
> > only a list not a function.
> > 
> Hrm... the specific mapping is a function. You are mixing with the
> blacklist field.

Indeed I was.

> > Is it possible that the 52xx DTBs have caught up and these are no longer
> > required even there though?
> The chipid is not defined in the device tree bindings. IIRC, it's not
> the case for the PWM region. I will have to check the code.
> Regards,

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.