[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 2/3] xen: introduce arch_grant_(un)map_page_identity
>>> On 28.07.14 at 12:16, <stefano.stabellini@xxxxxxxxxxxxx> wrote: > Changes in v4: > - declare the x86 implementations as extern; What you say here is what I asked for, but ... > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -1905,6 +1905,19 @@ out: > rcu_unlock_domain(fdom); > return rc; > } > + > + > +int arch_grant_map_page_identity(struct domain *d, unsigned long frame, > + bool_t writeable) > +{ > + return -ENOSYS; > +} > + > +int arch_grant_unmap_page_identity(struct domain *d, unsigned long frame) > +{ > + return -ENOSYS; > +} > + ... what's this (not to speak of the double blank line you introduce)? I specifically said declare but don't define, to catch problems at build rather than run time. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |