Re: [Xen-devel] [PATCH 2/2] xen: arm: update arm32 assembly primitives to Linux v3.16-rc6

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 07/25/2014 04:48 PM, Ian Campbell wrote:
> On Fri, 2014-07-25 at 16:42 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 07/25/2014 04:22 PM, Ian Campbell wrote:
>>> bitops, cmpxchg, atomics: Import:
>>>   c32ffce ARM: 7984/1: prefetch: add prefetchw invocations for barriered 
>>> atomics
>>
>> Compare to Linux we don't have specific prefetch* helpers. We directly
>> use the compiler builtin ones. Shouldn't we import the ARM specific
>> helpers to gain in performance?
> 
> My binaries are full of pld instructions where I think I would expect
> them, so it seems like the compiler builtin ones are sufficient.
> 
> I suspect the Linux define is there to cope with older compilers or
> something.

If so:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel