[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] hvm/hpet: Alter hpet_init() to take a domain rather than vcpu

>>> On 25.07.14 at 15:19, <andrew.cooper3@xxxxxxxxxx> wrote:
> There is nothing vcpu-specific about hpet_init(); all it does is follow the
> vcpu's domain pointer to get at the domain vhpet state.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> ---
> Despite the comment in scope in hvm_vcpu_initialise(), the call can't
> currently be moved to hvm_domain_initialise() as the extra hpet_deinit() (in
> an error path) needs an allocated vcpu which wouldn't be present at that
> point.  I need more tuits to disentangle that mess.

And indeed I was about to ask that very question. Thanks for the
patch in any case!


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.