Re: [Xen-devel] [PATCH] xen/lib: Annotate debugtrace_printk() with a printf compiler __attribute__

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.07.14 at 15:11, <andrew.cooper3@xxxxxxxxxx> wrote:
> And fix up the resulting compilation issue.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

with a question perhaps more to Tim than to you:

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1807,7 +1807,7 @@ void audit_p2m(struct domain *d,
>   
>      P2M_PRINTK("p2m audit complete\n");
>      if ( orphans_count | mpbad | pmbad )
> -        P2M_PRINTK("p2m audit found %lu orphans\n", orphans);
> +        P2M_PRINTK("p2m audit found %lu orphans\n", orphans_count);
>      if ( mpbad | pmbad )
>      {
>          P2M_PRINTK("p2m audit found %lu odd p2m, %lu bad m2p entries\n",

Seeing both of the if() conditions - is the first one really usefully or-ing
in mpbad and pmbad?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel