[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC V3 1/5] xen: Emulate with no writes
On 07/24/2014 02:20 PM, Tim Deegan wrote: > Hi, > > At 15:34 +0300 on 23 Jul (1406126080), Razvan Cojocaru wrote: >> +static const struct x86_emulate_ops hvm_emulate_ops_no_write = { >> + .read = hvmemul_read, >> + .insn_fetch = hvmemul_insn_fetch, >> + .write = hvmemul_write_discard, >> + .cmpxchg = hvmemul_cmpxchg, >> + .rep_ins = hvmemul_rep_ins, >> + .rep_outs = hvmemul_rep_outs, >> + .rep_movs = hvmemul_rep_movs, > > If you want to discard all writes from this guest instruction, you'll > also need modified versions of the rep_ins, rep_movs and cmpxchg > handlers. Since this seems to have been the only comment on this particular patch so far, would it be safe to assume that once the issue is addressed the patch is acceptable? Thanks, Razvan Cojocaru _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |