[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 1/3] xen/x86: introduce is_domain_direct_mapped(d) as (0) on x86
On Thu, 24 Jul 2014, Julien Grall wrote: > Hi Stefano, > > On 07/24/2014 02:31 PM, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> > > --- > > xen/include/asm-x86/domain.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h > > index abf55fb..5f9354b 100644 > > --- a/xen/include/asm-x86/domain.h > > +++ b/xen/include/asm-x86/domain.h > > @@ -19,6 +19,7 @@ > > #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \ > > d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector) > > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) > > +#define is_domain_direct_mapped(d) (0) > > When I've implemented this defined in common/memory.c, Jan told me to > use [1]: > > #define is_domain_is_direct_mapped(d) ((void)(d), 0) > > I suspect you want the same things here. OK > Also, could you drop the define in common/memory.c. I don't think it's > useful now. I'll do > > > #define VCPU_TRAP_NMI 1 > > #define VCPU_TRAP_MCE 2 > > > > Regards, > > [1] https://patches.linaro.org/22523/ > > -- > Julien Grall > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |