Re: [Xen-devel] [PATCH v4 1/3] libxl IDL: the name of a KeyedUnion descriminator need not be 'type'

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-07-22 at 16:05 +0100, David Scott wrote:
> Signed-off-by: David Scott <dave.scott@xxxxxxxxxx>

"discriminator"

Since there are no existing KeyedUnions who's discriminator is not
"type" there should be no change to the resulting code, but I've not
gone and confirmed that myself.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I've applied this one and fixed the typo on the way.

> ---
>  tools/libxl/gentypes.py |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/gentypes.py b/tools/libxl/gentypes.py
> index 4b0c996..3e73821 100644
> --- a/tools/libxl/gentypes.py
> +++ b/tools/libxl/gentypes.py
> @@ -440,7 +440,7 @@ def libxl_C_type_parse_json(ty, w, v, indent = "    ", 
> parent = None, discrimina
>                           (f.type.keyvar.name + "." + x.name, w)
>                      s += "    if (x) {\n"
>                      (nparent, fexpr) = ty.member(v, f.type.keyvar, parent is 
> None)
> -                    s += "        %s_init_type(%s, %s);\n" % (ty.typename, 
> v, x.enumname)
> +                    s += "        %s_init_%s(%s, %s);\n" % (ty.typename, 
> f.type.keyvar.name, v, x.enumname)
>                      (nparent,fexpr) = ty.member(v, f, parent is None)
>                      s += libxl_C_type_parse_json(f.type, "x", fexpr, "  ", 
> nparent, x.enumname)
>                      s += "    }\n"





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel