Re: [Xen-devel] [PATCH v3 3/3] xen/arm: introduce XENFEAT_grant_map_identity

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.07.14 at 16:10, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Thu, 24 Jul 2014, Jan Beulich wrote:
>> >>> On 24.07.14 at 15:31, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> > --- a/xen/common/grant_table.c
>> > +++ b/xen/common/grant_table.c
>> > @@ -727,7 +727,7 @@ __gnttab_map_grant_ref(
>> >  
>> >      double_gt_lock(lgt, rgt);
>> >  
>> > -    if ( gnttab_need_iommu_mapping(ld) )
>> > +    if ( gnttab_need_iommu_mapping(ld) || 
>> > gnttab_need_identity_mapping(ld) 
> )
>> 
>> As before I think this change is pointless.
> 
> I don't understand how you propose to solve the problem.

I think ARM's gnttab_need_iommu_mapping() needs to just be
is_domain_direct_mapped() then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel