Re: [Xen-devel] [PATCH v8 3/7] xen/arm: Add support for GIC v3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-07-23 at 18:28 +0100, Julien Grall wrote:
> Hi Vijay,
> 
> On 07/23/2014 02:41 PM, vijay.kilari@xxxxxxxxx wrote:
> > +#define GICD_PIDR2_ARCH_REV_MASK     (0xf0)
> > +#define GICD_PIDR2_ARCH_REV_OFFSET   (0x4)
> 
> NIT: We tend to use SHIFT rather than OFFSET.
> 
> > +#define GICD_PIDR2_ARCH_GICV3        (0x3)
> > +#define GICD_PIDR2_USES_JEP_MASK     (0x08)
> > +#define GICD_PIDR2_JEP_ID_MASK       (0x07)
> 
> NIT: I don't see any usage of GICD_PIDR2_USES_JEP_MASK and
> GICD_PIDR2_JEP_ID_MASK.
> 
> Hence, you don't define the SHIFT. So I would drop them.

FWIW I don't think it is a problem define bits of a register which
aren't currently used on the principal that including the full set is a
reasonable choice.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel