Re: [Xen-devel] [PATCH v8 07/10] xen/arm: remove workaround to inject evtchn_irq on irq enable

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 23 Jul 2014, Stefano Stabellini wrote:
> On Thu, 17 Jul 2014, Ian Campbell wrote:
> > On Thu, 2014-07-10 at 19:13 +0100, Stefano Stabellini wrote:
> > > evtchn_upcall_pending is already set by common code at vcpu creation,
> > > therefore on ARM we also need to call vgic_vcpu_inject_irq for it.
> > > Currently we do that from vgic_enable_irqs as a workaround.
> > 
> > Perhaps we should gate these on evtchn_upcall_pending then? That would
> > make it pretty obvious in most places what it was for.
> > 
> > Other than that suggestion and Julien's request for a comment this looks
> > good to me.
> 
> Makes sense, I'll make the changes

I take it back: checking evtchn_upcall_pending wouldn't work because it
hasn't been set yet. I think it's best not to introduce a dependency on
the order of the calls.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel