Re: [Xen-devel] [PATCH] xen/pciback: Fix error return code in xen_pcibk_attach()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.07.14 at 07:46, <weiyj_lk@xxxxxxx> wrote:
> --- a/drivers/xen/xen-pciback/xenbus.c
> +++ b/drivers/xen/xen-pciback/xenbus.c
> @@ -174,6 +174,7 @@ static int xen_pcibk_attach(struct xen_pcibk_device *pdev)
>                                "version mismatch (%s/%s) with pcifront - "
>                                "halting " DRV_NAME,
>                                magic, XEN_PCI_MAGIC);
> +             err = -EFAULT;
>               goto out;
>       }
>  

While -EFAULT is kind of odd here, I realize this is because the same
also gets passed to xenbus_dev_fatal(); -EILSEQ, -ENODATA, or
-EPROTO (despite it normally being network specific) would seem
better to me.

In any event
Reviewed-by Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel