[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Commit dd6d87 breaks serial console

>>> On 14.07.14 at 18:07, <roger.pau@xxxxxxxxxx> wrote:
> The following commit:
> commit dd6d87a4fcc8350c752e389abb3bcd8479c37555
> Author: Jan Beulich <jbeulich@xxxxxxxx>
> Date:   Fri Jun 20 10:26:37 2014 +0200
>     VT-d: drop redundant calls to invalidate_sync()
>     The call tree iommu_flush_iec_index() -> __iommu_flush_iec() already
>     invokes invalidate_sync(). Removing the superfluous instances at once
>     allows the function to become static.
>     Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>     Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>     Acked-by: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> Breaks serial console on my box, this is all the output I get with this 
> commit applied:
> [...]
> I'm attaching a revert of this patch, which makes serial output on my 
> box work as expected.

Just to augment what others already said - in situations like this,
requesting a revert without any understanding/explanation of
what's actually wrong, or at least under what specific conditions
the issue occurs (since clearly the serial console has been working
fine for me and likely others) is generally insufficient.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.