Re: [Xen-devel] xen-unstable stubdom build-failure when debug=n

[Olaf Hering <olaf@xxxxxxxxx>]

On Mon, Jul 21, Olaf Hering wrote:

> On Mon, Jul 21, Ian Campbell wrote:
> 
> > If that were the case then I'd expect
> >         git clean -ffffdqx && ./configure && make debug=n ; make debug=n
> > to work as well, which it doesn't seem to.
> > 
> > My guest is that turning off debug increases the optimisation level
> > which somehow makes gcc decide this code is now wrong.
> 
> How does stubdom the build tests anyway?

Here is the actual log:

[  6%] Building C object tpm/CMakeFiles/tpm.dir/tpm_credentials.o
cd /home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/build/tpm 
&& /usr/bin/gcc   -std=c99 -DTPM_NO_EXTERN -isystem 
/home/olaf/work/github/olafhering/xen/stubdom/../extras/mini-os/include 
-D__MINIOS__ -DHAVE_LIBC -isystem 
/home/olaf/work/github/olafhering/xen/stubdom/../extras/mini-os/include/posix 
-isystem /home/olaf/work/github/olafhering/xen/stubdom/../tools/xenstore  
-isystem 
/home/olaf/work/github/olafhering/xen/stubdom/../extras/mini-os/include/x86 
-isystem 
/home/olaf/work/github/olafhering/xen/stubdom/../extras/mini-os/include/x86/x86_64
 -U __linux__ -U __FreeBSD__ -U __sun__ -nostdinc -isystem 
/home/olaf/work/github/olafhering/xen/stubdom/../extras/mini-os/include/posix 
-isystem 
/home/olaf/work/github/olafhering/xen/stubdom/cross-root-x86_64/x86_64-xen-elf/include
 -isystem /usr/lib64/gcc/x86_64-suse-linux/4.3/include -isystem 
/home/olaf/work/github/olafhering/xen/stubdom/lwip-x86_64/src/include -isystem 
/home/olaf/work/github/olafhering/xen/stubdom/lwip-x86_64/src/include/ipv4 
-I/home/olaf/work/github/olafhering/xen/stubdom/include 
-I/home/olaf/work/github/olafhering/xen/stubdom/../xen/include -mno-red-zone 
-O2 -O1 -fomit-frame-pointer  -m64 -mno-red-zone -fno-reorder-blocks 
-fno-asynchronous-unwind-tables -m64 -fno-strict-aliasing -std=gnu99 -Wall 
-Wstrict-prototypes -Wdeclaration-after-statement   -fno-stack-protector 
-fno-exceptions -Wno-declaration-after-statement -I/opt/local/include 
-I/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64 
-I/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/build   
-Wall -Werror -Wno-unused-parameter -Wpointer-arith -Wcast-align 
-Wwrite-strings -Wextra -o CMakeFiles/tpm.dir/tpm_credentials.o   -c 
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c
cc1: warnings being treated as errors
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c:
 In function 'TPM_CreateEndorsementKeyPair':
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c:52:
 error: unused parameter 'antiReplay'
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c:53:
 error: unused parameter 'keyInfo'
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c:54:
 error: unused parameter 'pubEndorsementKey'
/home/olaf/work/github/olafhering/xen/stubdom/tpm_emulator-x86_64/tpm/tpm_credentials.c:55:
 error: unused parameter 'checksum'
make[5]: *** [tpm/CMakeFiles/tpm.dir/tpm_credentials.o] Error 1


Why does that only fail for me?
Is "-Wall -Werror -Wextra" different in sles11?

Looks like it should fail everywhere:
stubdom/tpm_emulator-x86_64/CMakeLists.txt
 43 add_definitions(-Wall -Werror -Wno-unused-parameter -Wpointer-arith 
-Wcast-align -Wwrite-strings)
 44 if("${CMAKE_SYSTEM}" MATCHES "Linux")
 45     add_definitions(-Wextra)
 46 endif()

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel