Re: [Xen-devel] [PATCH v3 10/10] xen: arm: Only lookup kernel bootmodule once while building dom0 dtb.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 18/07/14 14:08, Ian Campbell wrote:
> diff --git a/xen/arch/arm/kernel.h b/xen/arch/arm/kernel.h
> index 7c7f624..2745bb5 100644
> --- a/xen/arch/arm/kernel.h
> +++ b/xen/arch/arm/kernel.h
> @@ -23,6 +23,7 @@ struct kernel_info {
>       paddr_t entry;
>
>       /* boot blob load addresses */
> +    struct bootmodule *bootmodule;
If you don't read the assignment in the code you don't know to which 
module the variable pointed to. I would rename to smth like kernelmodule.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel